[PATCH] D60160: [PowerPC] Update P9 vector costs for insert/extract element

[Jinsong Ji via Phabricator via llvm-commits]

jsji added inline comments.


================
Comment at: llvm/test/Analysis/CostModel/PowerPC/p9.ll:2
 ; RUN: opt < %s -cost-model -analyze -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr7 -mattr=+vsx | FileCheck %s
+; RUN: opt < %s -cost-model -analyze -mtriple=powerpc64le-unknown-linux-gnu -mcpu=pwr8 -mattr=+vsx | FileCheck --check-prefix=CHECK-P8 %s
 ; RUN: opt < %s -cost-model -analyze -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr9 -mattr=+vsx | FileCheck --check-prefix=CHECK-P9 %s
----------------
RKSimon wrote:
> jsji wrote:
> > Can we have another NFC patch to rename the check-prefixes to avoid confusion. 
> > 
> > Now `CHECK` default to P7, while `CHECK-P8` is for P8 LE, `CHECK-P9` is for P9 BE, `CHECK-LE` is for P9 LE.
> > 
> > Maybe `CHECK-P7`, `CHECK-P8LE`, `CHECK-P9BE`, `CHECK-P9LE` would be better? 
> > 
> > Also maybe use multiple prefixes to check common ones, so that we don't need too many duplicates.
> > eg: `--check-prefixes=CHECK,CHECK-P7` for `P7`,
> > `--check-prefixes=CHECK,CHECK-P8LE` for `P8 LE`.
> > 
> Not sure if you're interested, but you can use llvm\utils\update_analyze_test_checks.py to automatically generate cost checks to reduce manual labour.
Good suggestion, Thanks Simon!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60160/new/

https://reviews.llvm.org/D60160