[PATCH] D60382: FileCheck [2/12]: Stricter parsing of -D option

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In D60382#1466257 <https://reviews.llvm.org/D60382#1466257>, @thopre wrote:

> Therefore, if we want to remove the diagnostic from that function we need to remove the ability to define a numeric variable from a numeric expression (which allows stuff like -D#NUMVAR1=10 -D#NUMVAR2=NUMVAR1+4. How useful do you think this ability is?


I have no idea how useful this would be, but you're making a reasonable argument that in general the library needs to be where the validation occurs, because the acceptable syntax is determined by the library.
Just make it clear to the user where the problem is and what needs fixing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60382/new/

https://reviews.llvm.org/D60382