[PATCH] D60376: [llvm-objdump] Align instructions to a tab stop in disassembly output

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

In D60376#1468514 <https://reviews.llvm.org/D60376#1468514>, @MaskRay wrote:

> @rupprecht Some people's editors are configured to replace tabs with spaces. And here, I want to test the tab takes exactly one column. I relanded this revision and it seems 'tr' works.


Even in editors that do this, there is usually a way to enter it literally, and some tests have literal tabs in them for this cases like this. And editor hooks that might do this usually don't do this for any file -- e.g. a clang-format hook would run on a .cpp file and remove tabs there, but since tabs are significant in Makefile, no hooks would strip tabs there.

It's not clear to me what the test is testing. If the concern is that tabs aren't visible, maybe it would be better to use `tr` to convert tabs to a visible character like `x` or `t`, so you can be clearer about where you expect tabs and where you expect spaces?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60376/new/

https://reviews.llvm.org/D60376