[PATCH] D60744: lld: elf: Fix sections with explict addresses in regions

Tue Apr 16 02:27:55 PDT 2019

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

This change seems correct, although it is a bit tricky and perhaps unnecessary to move `.` backwards in many linker scripts.

================
Comment at: lld/ELF/LinkerScript.cpp:769

+  if (Sec->Flags & SHF_ALLOC && Sec->AddrExpr)
+    setDot(Sec->AddrExpr, Sec->Location, false);
----------------
Add `()` to group `&` operator for those who don't remember which has a higher predence, & or &&.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60744/new/

https://reviews.llvm.org/D60744