[PATCH] D60250: [llvm-objdump] Allow -dynamic-reloc on ET_EXEC files

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks good, aside from one comment about the tests.



================
Comment at: llvm/test/tools/llvm-objdump/dynamic-reloc-dyn.test:11
+  Data:            ELFDATA2LSB
+  Type:            ET_DYN
+  Machine:         EM_X86_64
----------------
To show that the ELF type isn't important, I'd be tempted to change this to either ET_EXEC, or possibly some arbitrary value e.g. 0x1234. Same with the other test. I think the two tests should use the same ELF type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60250/new/

https://reviews.llvm.org/D60250