[PATCH] D60760: Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO

Stephan Bergmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 01:08:43 PDT 2019


sberg marked an inline comment as done.
sberg added inline comments.


================
Comment at: compiler-rt/lib/ubsan/ubsan_type_hash_itanium.cc:264
+  return SANITIZER_NON_UNIQUE_TYPEINFO && TI1->__type_name[0] != '*' &&
+         TI2->__type_name[0] != '*' &&
+         !internal_strcmp(TI1->__type_name, TI2->__type_name);
----------------
My understanding of that GCC * prefix hack is that would should check symmetrically for both type_infos (which is different how isDerivedFromAtOffset above did it in the past)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60760/new/

https://reviews.llvm.org/D60760





More information about the llvm-commits mailing list