[PATCH] D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 01:02:55 PDT 2019


hans added a comment.

In D59936#1467261 <https://reviews.llvm.org/D59936#1467261>, @dmgreen wrote:

> What are you thinking is best here? I agree that lifetime.end shouldn't prohibit optimisations. Do you think it's best to fix asan and go with this as-is, or to try and prevent sinking if it will //only// sink a lifetime.time?


I think it's best to fix asan and re-commit this as-is. I'll do that once the asan fix (r358478) has baked a little.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59936/new/

https://reviews.llvm.org/D59936





More information about the llvm-commits mailing list