[PATCH] D60470: [DWARF] Prefer larger DW_AT_low_pc when constructing aranges

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 21:53:44 PDT 2019


smeenai added a comment.

In D60470#1467862 <https://reviews.llvm.org/D60470#1467862>, @MaskRay wrote:

> In D60470#1467587 <https://reviews.llvm.org/D60470#1467587>, @t.p.northover wrote:
>
> > Have you run make check on this patch?
>
>
> If you meant llvm-objdump `-exports-trie`. It was my problem and I apologize for the llvm-objdump test failure I caused. Or https://reviews.llvm.org/D60376 where I didn't notice BSD sed's escape character support for `y` command is different from GNU sed on Linux. ("The meaning of a <backslash> followed by any character that is not 'n', a <backslash>, or the delimiter character is undefined."). Thank you for telling that there is `ninja check` beside `check-all` `check-llvm` ..., but those discussions are unrelated to this revision.


`check` is just an alias for `check-llvm`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60470/new/

https://reviews.llvm.org/D60470





More information about the llvm-commits mailing list