[PATCH] D60644: [compiler-rt][builtins][sanitizers] Guard test cases with macros to run when specific version of GLIBC is detected

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

In D60644#1466135 <https://reviews.llvm.org/D60644#1466135>, @rupprecht wrote:

> Part of me thinks this is bad -- if the version of glibc is old, then the host toolchain should just upgrade it. glibc 2.23 was released in 2016-02-19, so I think using something older than that is on the border of being called "not a modern c++ toolchain".


We talk of needing a "modern C++ toolchain" for building the project; however, in the case of `compiler_rt_logb_test`, we are talking not of the build environment, but rather the supporting libraries on a system where compiler-rt may be deployed. Perhaps the tests are currently set up to run in the build environment, but is not a stretch to imagine that the tests can be run as part of an installer for deploying the build.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60644/new/

https://reviews.llvm.org/D60644