[llvm] r358472 - [llvm-objdump] Simplify PrintHelpMessage() logic
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 15 19:37:29 PDT 2019
Author: maskray
Date: Mon Apr 15 19:37:29 2019
New Revision: 358472
URL: http://llvm.org/viewvc/llvm-project?rev=358472&view=rev
Log:
[llvm-objdump] Simplify PrintHelpMessage() logic
This relands rL358418. It missed one test that should also use -macho
Note, all the other -private-header -exports-trie tests are used
together with -macho.
Modified:
llvm/trunk/test/Object/objdump-export-list.test
llvm/trunk/test/tools/llvm-objdump/X86/macho-private-header.test
llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
Modified: llvm/trunk/test/Object/objdump-export-list.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/objdump-export-list.test?rev=358472&r1=358471&r2=358472&view=diff
==============================================================================
--- llvm/trunk/test/Object/objdump-export-list.test (original)
+++ llvm/trunk/test/Object/objdump-export-list.test Mon Apr 15 19:37:29 2019
@@ -1,4 +1,5 @@
-RUN: llvm-objdump -exports-trie %p/Inputs/macho-no-exports.dylib | FileCheck %s
+RUN: llvm-objdump -macho -exports-trie %p/Inputs/macho-no-exports.dylib | FileCheck %s
; Test that we don't crash with an empty export list.
-CHECK: macho-no-exports.dylib: file format Mach-O 64-bit x86-64
+CHECK: macho-no-exports.dylib
+CHECK: Exports trie:
Modified: llvm/trunk/test/tools/llvm-objdump/X86/macho-private-header.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/X86/macho-private-header.test?rev=358472&r1=358471&r2=358472&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-objdump/X86/macho-private-header.test (original)
+++ llvm/trunk/test/tools/llvm-objdump/X86/macho-private-header.test Mon Apr 15 19:37:29 2019
@@ -1,4 +1,4 @@
-// RUN: llvm-objdump -private-header %p/Inputs/hello.obj.macho-x86_64 | FileCheck %s
+// RUN: llvm-objdump -macho -private-header %p/Inputs/hello.obj.macho-x86_64 | FileCheck %s
CHECK: Mach header
CHECK: magic cputype cpusubtype caps filetype ncmds sizeofcmds flags
Modified: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp?rev=358472&r1=358471&r2=358472&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp (original)
+++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp Mon Apr 15 19:37:29 2019
@@ -2008,34 +2008,15 @@ int main(int argc, char **argv) {
if (DisassembleAll || PrintSource || PrintLines)
Disassemble = true;
- if (!Disassemble
- && !Relocations
- && !DynamicRelocations
- && !SectionHeaders
- && !SectionContents
- && !SymbolTable
- && !UnwindInfo
- && !PrivateHeaders
- && !FileHeaders
- && !FirstPrivateHeader
- && !ExportsTrie
- && !Rebase
- && !Bind
- && !LazyBind
- && !WeakBind
- && !RawClangAST
- && !(UniversalHeaders && MachOOpt)
- && !ArchiveHeaders
- && !(IndirectSymbols && MachOOpt)
- && !(DataInCode && MachOOpt)
- && !(LinkOptHints && MachOOpt)
- && !(InfoPlist && MachOOpt)
- && !(DylibsUsed && MachOOpt)
- && !(DylibId && MachOOpt)
- && !(ObjcMetaData && MachOOpt)
- && !(!FilterSections.empty() && MachOOpt)
- && !FaultMapSection
- && DwarfDumpType == DIDT_Null) {
+ if (!ArchiveHeaders && !Disassemble && DwarfDumpType == DIDT_Null &&
+ !DynamicRelocations && !FileHeaders && !PrivateHeaders && !RawClangAST &&
+ !Relocations && !SectionHeaders && !SectionContents && !SymbolTable &&
+ !UnwindInfo && !FaultMapSection &&
+ !(MachOOpt &&
+ (Bind || DataInCode || DylibId || DylibsUsed || ExportsTrie ||
+ FirstPrivateHeader || IndirectSymbols || InfoPlist || LazyBind ||
+ LinkOptHints || ObjcMetaData || Rebase || UniversalHeaders ||
+ WeakBind || !FilterSections.empty()))) {
cl::PrintHelpMessage();
return 2;
}
More information about the llvm-commits
mailing list