[PATCH] D60644: [compiler-rt][builtins][sanitizers] Guard test cases with macros to run when specific version of GLIBC is detected

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 17:14:43 PDT 2019


amyk added a comment.

@hubert.reinterpretcast Thank you for reviewing and bringing up these concerns, I do understand and you do have a point.

In terms of `qdiv_test` and `divsc3_test`, do you think checking perhaps checking the version of GCC is a more suitable fix?

I could be mistaken, but doesn't the `getpw_getgr` test still succeed regardless if `-D_GLIBCXX_USE_CXX11_ABI` is set (within a toolchain that supports setting this)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60644/new/

https://reviews.llvm.org/D60644





More information about the llvm-commits mailing list