[PATCH] D60738: [MSP430AsmPrinter] Refactor special cases out of printOperand. NFC

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers created this revision.
nickdesaulniers added a reviewer: echristo.
Herald added subscribers: llvm-commits, hiraditya, eraman.
Herald added a project: LLVM.

Refactoring to make changing the interface later simpler (trying to
remove Modifier from printOperand).

printOperand has an ominous comment for MO_GlobalAddress, but then no
unit tests (from what I can tell).  Add some that pass before and after
changes, for fearless refactoring.

There is no "mem" modifier, so isMemOp is always false.

There's only special handling in the method printSrcMemOperand, so move
special logic there, simplifying printOperand.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60738

Files:
  llvm/lib/Target/MSP430/MSP430AsmPrinter.cpp
  llvm/test/CodeGen/MSP430/inline-asm-absolute-addressing.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60738.195271.patch
Type: text/x-patch
Size: 4578 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190415/16c107cd/attachment.bin>