[PATCH] D60294: [DAGCombiner] [CodeGenPrepare] WIP/RFC Splitting large offsets from base addresses

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I wasn't thinking in terms of keeping the addressing mode legal, just avoiding destroying the work of constant hoisting.  Constant hoisting won't split a constant in the way you're suggesting.  And it's relatively easy to write patterns to split "load x+c" in the most efficient way if "c" has a single use.  I guess the more restrictive version would allow splitting single-use constants as a DAGCombine, or earlier?  Not sure why you'd want to, though.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60294/new/

https://reviews.llvm.org/D60294