[PATCH] D60630: [Support] Add a test for recursive response file expansion

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai marked 2 inline comments as done.
smeenai added inline comments.


================
Comment at: llvm/unittests/Support/CommandLineTest.cpp:730
+  sys::path::append(ResponseFilePath, TestDir, "recursive.rsp");
+  std::string ResponseFileRef = std::string("@") + ResponseFilePath.c_str();
+
----------------
hans wrote:
> Not that it matters, but would using .str() instead of .c_str() work (relying on StringRef's conversion operator to std::sttring)?
That doesn't work, cos it tries to create a Twine. I could do `.str().str()`, but I don't think that's cleaner.


================
Comment at: llvm/unittests/Support/CommandLineTest.cpp:732
+
+  std::ofstream ResponseFile(ResponseFilePath.c_str());
+  EXPECT_TRUE(ResponseFile.is_open());
----------------
hans wrote:
> ditto
Sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60630/new/

https://reviews.llvm.org/D60630