[PATCH] D60686: Asan use-after-scope: don't poison allocas if there were untraced lifetime intrinsics in the function (PR41481)
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 15 13:39:40 PDT 2019
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
Consider extending the test with another alloca which does not participate in any untraceable lifetimes, but has to be poisoned in entry block anyway.
================
Comment at: llvm/test/Instrumentation/AddressSanitizer/stack-poisoning-and-lifetime.ll:223
+ ; Since we cannot account for all lifetime intrinsics in this function, we
+ ; might have missed a lifetime.start one and therefore shouldn't poison the
+ ; allocas at function entry.
----------------
did you mean "should poison"?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60686/new/
https://reviews.llvm.org/D60686
More information about the llvm-commits
mailing list