[llvm] r358405 - [llvm-objdump] Align instructions to a tab stop in disassembly output

Alex L via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 13:02:03 PDT 2019


Hi Fangrui,

As Tim pointed out, it looks like your commit relies on features that broke
this particular test on the darwin buildbots. This is the failure we're
seeing:

Command Output (stderr): -- sed: 1: "y/\t/ /": transform strings are not
the same length FileCheck error: '-' is empty. FileCheck command line:
/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/clang-build/bin/FileCheck
-strict-whitespace
/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm/test/tools/llvm-objdump/X86/disassemble-align.s

Could you please take a look? Here's the full log:
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/60093/consoleFull

Please let me know if you need any help reproducing the failure.
Cheers,
Alex


On Mon, 15 Apr 2019 at 12:25, Tim Northover via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Mon, 15 Apr 2019 at 14:30, Fangrui Song via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > +# RUN: llvm-objdump -d -print-imm-hex %t | sed 'y/\t/ /' | FileCheck
> -strict-whitespace %s
>
> This sed command looks like it relies on GNU specific features. Could
> you fix it or revert please?
>
> Tim.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190415/5c0e0cdb/attachment.html>


More information about the llvm-commits mailing list