[PATCH] D60674: [X86] Restore the pavg intrinsics.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 12:40:56 PDT 2019


craig.topper added a comment.

In D60674#1467349 <https://reviews.llvm.org/D60674#1467349>, @efriedma wrote:

> > Though I modified the avx512 intrinsics to not have masking built in.
>
> Do we need autoupgrade support from the old avx512 intrinsics to the new avx512 intrinsics?


Yes, and the code at 1548 in AutoUpgrade.cpp does that. There are existing tests in avx512bw-intrinsics-upgrade.ll and avx512bwvl-intrinsics-upgrade.ll that were previously testing upgrade from old intrinsics to pure IR that now just test old intrinsics to new intrinsics. The codegen is the same so they weren't affected by the patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60674/new/

https://reviews.llvm.org/D60674





More information about the llvm-commits mailing list