[PATCH] D60723: [EarlyCSE] detect equivalence of selects with inverse conditions and commuted operands (PR41101)

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/EarlyCSE.cpp:185
+      }
+      return hash_combine(Inst->getOpcode(), Pred, TVal, FVal);
+    }
----------------
nikic wrote:
> Shouldn't the cmp operands be hashed as well?
Good question. IIUC, this is not logically wrong, but using the cmp operands would improve the hashing (reduce chances of collision). Does that sound right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60723/new/

https://reviews.llvm.org/D60723