[PATCH] D60635: [zorg] Add LLVM lab buildslaves for Windows/Ubuntu builders.

[Vlad Vereschaka via Phabricator via llvm-commits]

vvereschaka marked 2 inline comments as done.
vvereschaka added inline comments.


================
Comment at: buildbot/osuosl/master/config/builders.py:1050
 
+        {'name' : "lld-x86_64-ubuntu-fast",
+         'slavenames' : ["as-builder-4"],
----------------
gkistanova wrote:
> What build time do you expect for this builder?
> If something around 5 minutes per build, it might make sense to build each commit to get more selective and accurate blame list. To do so simply add `'mergeRequests': False,` here.
Currently this builder takes around 6-7 minutes including the regression tests. 


================
Comment at: buildbot/osuosl/master/config/slaves.py:265
+        create_slave("as-builder-2", properties={'jobs': 64}, max_builds=1),
+        create_slave("as-builder-3", properties={'jobs': 64}, max_builds=1),
+        # Ubuntu 18.04.2 LTS x86_64 Intel(R) Xeon(R) Gold CPU @ 2.1GHz, 128GB RAM
----------------
gkistanova wrote:
> These 3 slaves are not in use yet, right?
> Could you add them along with the builders to work on each, please?
> 
Yes, this is correct. I'll do it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60635/new/

https://reviews.llvm.org/D60635