[PATCH] D60727: [NVPTXAsmPrinter] clean up dead code. NFC

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 10:39:59 PDT 2019


nickdesaulniers created this revision.
nickdesaulniers added a reviewer: echristo.
Herald added subscribers: llvm-commits, hiraditya, jholewinski.
Herald added a project: LLVM.

The printOperand function takes a default parameter, for which there are
zero call sites that explicitly pass such a parameter.  As such, there
is no case to support. This means that the method
printVecModifiedImmediate is purly dead code, and can be removed.

The eventual goal for some of these AsmPrinter refactoring is to have
printOperand be a virtual method; making it easier to print operands
from the base class for more generic Asm printing. It will help if all
printOperand methods have the same function signature (ie. no Modifier
argument when not needed).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60727

Files:
  llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
  llvm/lib/Target/NVPTX/NVPTXAsmPrinter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60727.195225.patch
Type: text/x-patch
Size: 3766 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190415/8cef5360/attachment.bin>


More information about the llvm-commits mailing list