[PATCH] D60639: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 10:39:57 PDT 2019


yln marked an inline comment as done.
yln added inline comments.


================
Comment at: compiler-rt/test/tsan/Darwin/gcd-sync-block-copy.mm:3-6
+// RUN: %clang_tsan %s -o %t_no_tsan   -framework Foundation -fno-sanitize=thread
 // RUN: %clang_tsan %s -o %t_with_tsan -framework Foundation
+
+// RUN: %run %t_no_tsan   2>&1 | FileCheck %s
----------------
kubamracek wrote:
> What is this change doing?
It's just changing to compile both binaries first, (instead of compile, check, compile, check) so that it is easier to debug/compare outputs in case the FileCheck fails. Also reformat line, so it's obvious that the only difference between those two line is `-fno-sanitize=thread`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60639/new/

https://reviews.llvm.org/D60639





More information about the llvm-commits mailing list