[PATCH] D60718: [LoopPred] Stop passing around builders [NFC]

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 09:33:09 PDT 2019


reames created this revision.
reames added reviewers: fedor.sergeev, apilipenko.
Herald added subscribers: bollu, mcrosier.
Herald added a project: LLVM.

This is a preparatory patch for D60093 <https://reviews.llvm.org/D60093>.  This patch itself is NFC, but while preparing this I noticed and committed a small hoisting change in rL358419 <https://reviews.llvm.org/rL358419>.

The basic structure of the new scheme is that we pass around the guard ("the using instruction"), and select an optimal insert point by examining operands at each construction point.  This seems conceptually a bit cleaner to start with as it isolates the knowledge about insertion safety at the actual insertion point.

Note that the non-hoisting path is not actually used at the moment.  That's not exercised until D60093 <https://reviews.llvm.org/D60093> is rebased on this one.


Repository:
  rL LLVM

https://reviews.llvm.org/D60718

Files:
  lib/Transforms/Scalar/LoopPredication.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60718.195207.patch
Type: text/x-patch
Size: 9734 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190415/e7f66b65/attachment.bin>


More information about the llvm-commits mailing list