[PATCH] D60464: [pstl] Setup the _PSTL_VERSION macro like _LIBCPP_VERSION, and add release notes

Alexey Kukanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 09:24:15 PDT 2019


akukanov added a comment.

In D60464#1466986 <https://reviews.llvm.org/D60464#1466986>, @MikeDvorskiy wrote:

> In that case, may we "reserve" MINOR version to differ PSTL code version?


I think we first need to understand/agree whether we want to have milestones/releases that do not follow the LLVM release cadence while deserving separate versioning. According to the discussion at our last meeting, the answer tends to be "no" - in which case, I think we should keep full correspondence between the upstream PSTL version and the LLVM version.

At Intel, we will need to decide how to combine the upstream versioning with our own one. We have higher release cadence, but also smaller functionality increments. I think that we sometimes will be ahead of the upstream on functionality. I guess we will need a separate version macro; the relations with the upstream version, if any, will need to be clearly defined and documented.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60464/new/

https://reviews.llvm.org/D60464





More information about the llvm-commits mailing list