[PATCH] D59042: [SDA] Bug fix: Use IPD outside the loop as divergence bound

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

Oh wow. That's an important fix indeed :) LGTM



================
Comment at: lib/Analysis/SyncDependenceAnalysis.cpp:200
     if (ItLastDef->second != &DefBlock) {
+
       // do we know this join already?
----------------
Spurious whitespace


================
Comment at: lib/Analysis/SyncDependenceAnalysis.cpp:223
+                    SuccessorIterable NodeSuccessors, const Loop *ParentLoop, const BasicBlock * PdBoundBlock) {
 
+    assert(JoinBlocks);
----------------
Here as well.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59042/new/

https://reviews.llvm.org/D59042