[PATCH] D60700: [ARM] Change the MC names for VMAXNM/VMINNM.

Mon Apr 15 08:45:26 PDT 2019

simon_tatham added a comment.

It's true that during internal development we implemented this rename //before// the later change that adds some `UnsupportedFeatures` to the same schedule model which should rule out the MVE `VMAXNM`/`VMINNM` instructions in any case.

But if I revert the rename, it still fails, apparently before even getting as far as checking `UnsupportedFeatures`. The Tablegen error is

  llvm/lib/Target/ARM/ARMScheduleA57.td:755:1: error: Overlapping InstRW def VMAXNMAVf16 also matches (instregex "VMAX", "VMIN")
  def : InstRW<[A57Write_5cyc_1V], (instregex "VMAX", "VMIN")>;
  ^

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60700/new/

https://reviews.llvm.org/D60700