[PATCH] D60659: [InstCombine] Eliminate stores to constant memory

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D60659#1465605 <https://reviews.llvm.org/D60659#1465605>, @nicholas wrote:

> Why do you think a store through constant would break subtly? For most users I'd expect a store to a constant to correspond with a write to a read-only page causing a loud crash.


I assume you mean before this patch right?  If so, then yes and no.  It's possible the constant location is in a readonly page, but I have a lot of downstream constant locations which are intermixed with writeable data.  I'm sure other frontends might have the same.  Your reasoning may hold specifically for global constants though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60659/new/

https://reviews.llvm.org/D60659