[PATCH] D60698: [ARM] add target arch definitions for 8.1-M and MVE.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

> This adds:
> 
> - LLVM subtarget features to make all the new instructions conditional on
> - CPU and FPU names for use on armclang's command line, with default FPUs set so that "armv8.1-m.main+fp" and "armv8.1-m.main+fp.dp" will select the right FPU features
> - architecture extension names "mve" and "mve.fp"
> - ABI build attribute support for v8.1-M (a new value for Tag_CPU_arch) and MVE (a new actual tag)

Looks like they could be separate commits.  But if that makes things too complicated now, I think we can deal with this initial plumbing work.



================
Comment at: llvm/include/llvm/Support/ARMTargetParser.h:48
   AEK_SB      =     1 << 18,
+  AEK_FP_DP   =     1 << 19,
   // Unsupported extensions.
----------------
I think we need to regression test this new extension in `unittests/Support/TargetParserTest.cpp` too.


================
Comment at: llvm/lib/Support/ARMAttributeParser.cpp:137
+    "ARM v7E-M", "ARM v8", nullptr,
+    "ARM v8-M Baseline", "ARM v8-M Mainline", nullptr, nullptr, nullptr,
+    "ARM v8.1-M Mainline"
----------------
what are these nullptrs, and how many do we need? :-)
More seriously, I haven't looked into this bit before, but at least a comment would be good here I guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60698/new/

https://reviews.llvm.org/D60698