[PATCH] D60660: [InstCombine] Prune fshl/fshr with masked operands

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 05:40:07 PDT 2019


lebedev.ri added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:2100-2101
     if (SimplifyDemandedBits(II, 2, Op2Demanded, Op2Known))
       return &CI;
     break;
   }
----------------
shawnl wrote:
> lebedev.ri wrote:
> > I think that new code should be here.
> but it has to be above this:
> 
>     if (!isPowerOf2_32(BitWidth))
Good point, then place it just before that check :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60660/new/

https://reviews.llvm.org/D60660





More information about the llvm-commits mailing list