[PATCH] D60684: [llvm-readobj] Reapply: Improve error message for --string-dump

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 03:59:40 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. I'm slightly surprised the latter checks needed modifying (it's okay to though), but aside from that, this is fine.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60684/new/

https://reviews.llvm.org/D60684





More information about the llvm-commits mailing list