[llvm] r358392 - [AMDGPU] Fixed incorrect test in vcnd/vcmp optimization

Tim Renouf via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 03:36:24 PDT 2019


Author: tpr
Date: Mon Apr 15 03:36:24 2019
New Revision: 358392

URL: http://llvm.org/viewvc/llvm-project?rev=358392&view=rev
Log:
[AMDGPU] Fixed incorrect test in vcnd/vcmp optimization

This fixes a test I introduced in change D59191 (that added src0 and
src1 modifiers to the v_cndmask instruction for disassembly purposes).

Spotted by David Binderman in bug 41488.

Differential Revision: https://reviews.llvm.org/D60652

Change-Id: I6ac95e66cd84e812ed3359ad57bcd0e13198ba0c

Modified:
    llvm/trunk/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp

Modified: llvm/trunk/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp?rev=358392&r1=358391&r2=358392&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp Mon Apr 15 03:36:24 2019
@@ -223,7 +223,7 @@ static unsigned optimizeVcndVcmpPair(Mac
     return AMDGPU::NoRegister;
 
   if (TII->hasModifiersSet(*Sel, AMDGPU::OpName::src0_modifiers) ||
-      TII->hasModifiersSet(*Sel, AMDGPU::OpName::src0_modifiers))
+      TII->hasModifiersSet(*Sel, AMDGPU::OpName::src1_modifiers))
     return AMDGPU::NoRegister;
 
   Op1 = TII->getNamedOperand(*Sel, AMDGPU::OpName::src0);




More information about the llvm-commits mailing list