[PATCH] D60311: MIR printer should lowercase sub-register names to be in sync with parser?

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: lib/CodeGen/MachineOperand.cpp:767
       if (TRI)
-        OS << '.' << TRI->getSubRegIndexName(SubReg);
+        OS << '.' << StringRef(TRI->getSubRegIndexName(SubReg)).lower();
       else
----------------
bjope wrote:
> If the names should be both printed and parsed as lower case, then I think it would be better to update utils/TableGen/RegisterInfoEmitter.cpp to lower case all names in the SubRegIndexNameTable. That way we wouldn't have to mess around with lower casing names during runtime.
Besides, that would make all debug printouts consistent (all uses of getSubRegIndexName() would get the same casing for the name).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60311/new/

https://reviews.llvm.org/D60311