[PATCH] D60306: Fix -emit-reloc against local symbols.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 02:05:21 PDT 2019


grimar added inline comments.


================
Comment at: lld/trunk/test/ELF/emit-relocs-mergeable2.s:6
+
+# CHECK: 0000000000201004  000000010000000b R_X86_64_32S 0000000000200120 .Lfoo + 8
+
----------------
grimar wrote:
> I would suggest adding the header for these values and a short description of what this patch does.
> (I know we are missing the descriptions often, but ideally, I think we might want to add a description for each of
> our test. At least that is something I have in my TODO list for LLD and it is really useful sometimes).
what this patch does -> what this test checks


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60306/new/

https://reviews.llvm.org/D60306





More information about the llvm-commits mailing list