[PATCH] D60381: FileCheck [1/12]: Move variable table in new object

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 01:59:02 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit.



================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:47
+
+  // Clear local variables and check global variables remains defined.
+  Cxt.clearLocalVars();
----------------
Either variables -> variable or remains -> remain (but not both).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60381/new/

https://reviews.llvm.org/D60381





More information about the llvm-commits mailing list