[PATCH] D60067: [llvm-symbolizer] Add llvm-addr2line.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht requested changes to this revision.
rupprecht added a comment.
This revision now requires changes to proceed.

(requesting changes for one small bit, otherwise lgtm)



================
Comment at: docs/CommandGuide/llvm-addr2line.rst:7
+
+:program:`llvm-addr2line` [options]
+
----------------
I think this should be `[*options*]` (e.g. see llvm-objdump.rst)


================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:230
     Printer << (error(ResOrErr) ? DIInliningInfo() : ResOrErr.get());
+  } else if (IsAddr2Line) {
+    // With ClPrintFunctions == FunctionNameKind::LinkageName (default)
----------------
I think this should be `else if (ClOutputStyle == OutputStyle::GNU)`, if someone wants to use `llvm-symbolizer` directly but still have GNU addr2line compatability.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60067/new/

https://reviews.llvm.org/D60067