[PATCH] D60631: [Support] Fix recursive response file expansion guard

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

Looks good to me.



================
Comment at: llvm/lib/Support/CommandLine.cpp:1041
       continue;
+    } else {
+      ++ExpandedRspFiles;
----------------
How about getting rid of the negation in the if statement and instead doing:

```
if (ExpandResponseFile(..) {
  ++ExpandedRspFiles;
} else {
  // We couldn't read this file ...
}
```


================
Comment at: llvm/unittests/Support/CommandLineTest.cpp:773
+  std::string ResponseFileRef = std::string("@") + ResponseFilePath.c_str();
+  Argv.emplace_back(ResponseFileRef.c_str());
+
----------------
would push_back work instead? seems simpler


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60631/new/

https://reviews.llvm.org/D60631