[PATCH] D60660: [InstCombine] Prune fshl/fshr with masked operands

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:2087
+
+      if (SimplifyDemandedInstructionBits(*II))
+        return &CI;
----------------
lebedev.ri wrote:
> This should probably be at the top level of whatever function this is.
> Not sure where in the function though.
It should probably be right below this block. We already have the demanded bits simplification for the shift amount there (which we should probably move into the fshl handling in InstCombineSimplifyDemanded as a followup).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60660/new/

https://reviews.llvm.org/D60660