[PATCH] D32530: [SVE][IR] Scalable Vector IR Type

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 13 12:54:28 PDT 2019


rengolin added a comment.

In D32530#1464722 <https://reviews.llvm.org/D32530#1464722>, @hsaito wrote:

> If we are going for more than element-wise Instructions, we need to have well defined and agreed semantics for each of those, and that should be part of the LangRef for each such Instruction.


Agreed.

> Also, have we thought about Intrinsics? Can all Intrinsics that take/return non-scalable vector handle scalable vector?

Same for intrinsics. If any of the vector ones apply to scalable vectors (ex. reduce), it needs to be documented.

> We can certainly let element-wise stuff to go in first and then extend to non-element-wise stuff later. Any thoughts in this regard?

Precisely, we should go in baby-steps, with each step making sure we don't touch/break *anything* that isn't scalable, updating LangRef as we go.

Doing a single review on everything would be painful and counter-productive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D32530/new/

https://reviews.llvm.org/D32530





More information about the llvm-commits mailing list