[PATCH] D55699: Updated DynamicLibrary test to support static linking against MSVC RT.

Frederich Munch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 13 17:21:53 PDT 2019


marsupial added a comment.
Herald added a subscriber: dexonsmith.
Herald added a project: LLVM.

Sorry for the tardiness of this...

1. Could the the type change from **std::string** be to the new **State** type introduced (rather than **int**)
2. Have all **State** variables default initialized to a value that would cause the test to fail.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55699/new/

https://reviews.llvm.org/D55699





More information about the llvm-commits mailing list