[PATCH] D60659: [InstCombine] Eliminate stores to constant memory

[Nick Lewycky via Phabricator via llvm-commits]

nicholas added a comment.

The two statements:

> We could simply say that the store *is undefined*, and prune the path.

and

> The motivating case for this involves a memmove to a buffer which is constant down a path which is dynamically dead.

conspire to make me think that pruning the whole path really is the right thing to do. This might be the only hint the compiler has that the path is dead code.

Why do you think a store through constant would break subtly? For most users I'd expect a store to a constant to correspond with a write to a read-only page causing a loud crash.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60659/new/

https://reviews.llvm.org/D60659