[PATCH] D60657: [RISCV] Fix evaluation of %pcrel_lo
James Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 13 15:11:46 PDT 2019
jrtc27 added inline comments.
================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:59
+ MCFragment *FixupFragment = Fixup.getValue()->findAssociatedFragment();
+ ShouldForce = !TFragment || !FixupFragment ||
+ TFragment->getParent() != FixupFragment->getParent();
----------------
Is it even possible to not have a valid `FixupFragment`? Isn't that effectively how we found `T` in the first place in `getPCRelHiFixup`?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60657/new/
https://reviews.llvm.org/D60657
More information about the llvm-commits
mailing list