[PATCH] D60619: New pass to produce more easily-read IR.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1700
 
-  // Finally expand the basic registered passes from the .inc file.
+  // Finally expand the basic registered passes from PassRegistry.def.
 #define MODULE_PASS(NAME, CREATE_PASS)                                         \
----------------
Good catch! This is irrelevant to this revision. You may commit it separately.


================
Comment at: llvm/lib/Transforms/Utils/ImproveReadingOrder.cpp:51
+                                           FunctionAnalysisManager &FAM) {
+  BasicBlock * lastSoFar = nullptr;
+  std::set<BasicBlock *> processed;
----------------
`BasicBlock * lastSoFar = nullptr;` -> `BasicBlock *LastSoFar = nullptr;`
`for(` -> `for (`


https://llvm.org/docs/CodingStandards.html
`docs/Proposals/VariableNames.rst` (`lower_case` vs `lowerCase` is still a debate; (I prefer snake_case :) ))


================
Comment at: llvm/test/Transforms/Util/improve-reading-order.ll:1
+; RUN: opt -passes improve-reading-order < %s | FileCheck %s
+
----------------
Missing `-S`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60619/new/

https://reviews.llvm.org/D60619