[PATCH] D60649: [InstCombine] Remove redundant/bogus mul_with_overflow folds

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 13 02:50:42 PDT 2019


nikic added a comment.

@lebedev.ri Those aren't constant folds though. They fold to `{%x, false}`, which has to be created as something like `insertvalue {undef, false}, 0, %x`, which is non-constant. Or is the idea here more along the lines of folding `extractvalue addo(%x, 0), 1` to false in instsimplify? That would be possible, but doesn't seem like the right thing to do to me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60649/new/

https://reviews.llvm.org/D60649





More information about the llvm-commits mailing list