[PATCH] D60609: Use native llvm JSON library for time profiler output
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 13 01:33:21 PDT 2019
lebedev.ri added a comment.
In D60609#1465327 <https://reviews.llvm.org/D60609#1465327>, @takuto.ikuta wrote:
> I think it is true that json library is slower than just naive json output.
> But this code run one time in a compile and should have relatively few json objects.
> So visible performance effect will be low. Taking stats sounds good and I'm surprised if this patch change clang performance match.
Yes, that is my hope too, but given history i'd like to be confident :)
This will really depend on the number of the entries in the output.
I'd like to see perf measurements on some large compiler invocation, with *many* of these entries in output json report.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60609/new/
https://reviews.llvm.org/D60609
More information about the llvm-commits
mailing list