[PATCH] D60609: Use native llvm JSON library for time profiler output

Anton Afanasyev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 23:48:04 PDT 2019


anton-afanasyev marked an inline comment as done.
anton-afanasyev added a comment.

In D60609#1465292 <https://reviews.llvm.org/D60609#1465292>, @lebedev.ri wrote:

> I know this will sound redundant, but have you done performance measurements on this?
>  I recently had to revert a similar cleanup in D58584 <https://reviews.llvm.org/D58584>.


Wow, thanks to pointing this out! Using json library is obviously heavier than just streaming plain text, but I didn't suppose such perf regressions. I'm to measure it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60609/new/

https://reviews.llvm.org/D60609





More information about the llvm-commits mailing list