[PATCH] D60609: Use native llvm JSON library for time profiler output

Anton Afanasyev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 23:31:24 PDT 2019


anton-afanasyev marked 2 inline comments as done.
anton-afanasyev added a comment.

In D60609#1465222 <https://reviews.llvm.org/D60609#1465222>, @takuto.ikuta wrote:

> Thank you for follow up.


Thanks! I'm to push it after fixing one thing in JSON.h library which instantiates template function with warning.



================
Comment at: llvm/lib/Support/TimeProfiler.cpp:145
+                                {{"traceEvents", std::move(Events)}})))
+        << "\n";
   }
----------------
takuto.ikuta wrote:
> nit: I prefer to drop this new line.
Ok, done


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60609/new/

https://reviews.llvm.org/D60609





More information about the llvm-commits mailing list