[PATCH] D60644: [compiler-rt][builtins][sanitizers] Guard test cases with macros to run when specific version of GLIBC is detected

[Amy Kwan via Phabricator via llvm-commits]

amyk created this revision.
amyk added reviewers: vitalybuka, rupprecht, ddunbar.
amyk added projects: LLVM, Sanitizers.
Herald added subscribers: Sanitizers, jsji, kbarton, dberris, kubamracek.

On a platforms that we build LLVM on, we have some failing test cases that are related to the system's toolchain.

Three of the failing  test cases are testing compiler-rt builtins. These test cases have a dependency on comparing their computed values to the values of their libm counterparts. Our version of libm seems to be older, and thus we see errors and inconsistencies.

Another test is related to msan/sanitizer-common (getpw_getgr.cc) .There is one line that is problematic, and seems to be related to the version of GLIBC. In the past, this line was been disabled, as well; so others have also experiences failures with this specific test.

This patch explicitly aims to add macro guards for these four test cases. If a minimum version of GLIBC 2.23 is detected, then these tests are run. The version 2.23 was chosen because it is the version that I found has not been error-prone for these tests.

I've added some individuals who have worked with these test cases in the past as reviewers. I apologize if I missed anyone else. Please, if anyone has any comments or concerns on if these are suitable changes for these tests, I would greatly appreciate the feedback.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D60644

Files:
  compiler-rt/test/builtins/Unit/compiler_rt_logb_test.c
  compiler-rt/test/builtins/Unit/divsc3_test.c
  compiler-rt/test/builtins/Unit/ppc/qdiv_test.c
  compiler-rt/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60644.194957.patch
Type: text/x-patch
Size: 3581 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190413/93078324/attachment.bin>