[PATCH] D60580: [GlobalISel] Enable CSE in the IRTranslator & legalizer for -O0 with constants only

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 17:14:51 PDT 2019


aditya_nandakumar accepted this revision.
aditya_nandakumar added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks - please address the minor nit and proceed with two commits.



================
Comment at: llvm/include/llvm/CodeGen/CSEConfigBase.h:14
+// Class representing some configuration that can be done during GlobalISel's
+// CSEInfo analysis.
+class CSEConfigBase {
----------------
Could you please add a comment on why this class is defined here? Otherwise LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60580/new/

https://reviews.llvm.org/D60580





More information about the llvm-commits mailing list