[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9701
+static unsigned getAArch64LS(QualType QT, ParamKindTy Kind, ASTContext &C) {
+  if (getAArch64MTV(QT, Kind) && QT->isPointerType()) {
+    QualType PTy = QT->getPointeeType().getCanonicalType();
----------------
QT.getCanonicalType()->isPointerType()


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9832
+    OMPDeclareSimdDeclAttr::BranchStateTy State, StringRef MangledName,
+    char ISA, unsigned VecRegSize, llvm::Function *Fn, const Expr *VLENExpr) {
+
----------------
I would suggest to pass `SourceLocation` here rather than the `Expr *`. We need just a location.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60583/new/

https://reviews.llvm.org/D60583