[PATCH] D60598: [ConstantRange] Clarify makeGuaranteedNoWrapRegion() guarantees

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 12:02:16 PDT 2019


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

This is NFC since it only clarifies docs and adds respective test coverage, thanks.



================
Comment at: llvm/unittests/IR/ConstantRangeTest.cpp:1177-1178
+
+// Show that makeGuaranteedNoWrapRegion is precise if only one of
+// NoUnsignedWrap or NoSignedWrap is used.
+TEST(ConstantRange, NoWrapRegionExhaustive) {
----------------
Can we test/guarantee anything about the subset that will be returned if both are specified?
Naive guess - the most constrained range will be returned, the NSW one?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60598/new/

https://reviews.llvm.org/D60598





More information about the llvm-commits mailing list