[PATCH] D60604: [IR] Improve SwitchInst API to support prof branch_weights

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 11:49:02 PDT 2019


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

I'm not entirely sure about this interface.  I see there's precedent in code for working with the branch weights when removing cases, so I see where you're coming from, but the rest of our interface (e.g. branches) don't have an analogous API.

I think that if we're going to add an API like this, it needs to be uniform across all the terminator instructios.  Having it otherwise is just too confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60604/new/

https://reviews.llvm.org/D60604





More information about the llvm-commits mailing list